Glyph comments

Results 1070 comments of


                                            Glyph

add "local network access" permission for macOS 15 runners

oh, I guess [this is an option](https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners): > The Linux and macOS virtual machines both run using passwordless sudo. I could run some subset of the test suite as root...

add "local network access" permission for macOS 15 runners

@brianmichel have you managed to install this clicker agent automatically on a GHA runner? I'm wondering if there's any ready-to-use version of this.

add "local network access" permission for macOS 15 runners

@erik-bershel thank you for reopening! it would be great to have a solution before the last image that lets us test this functionality on any version of macOS ages out.

add "local network access" permission for macOS 15 runners

> I'm happy to share the xcconfig values and an example entitlements file when I get to work today if you might be interested in that [@glyph](https://github.com/glyph) just let me...

When a client has already closed the connection, error handlers registered with `@klein.app.Klein(...).handle_errors()` do not get invoked, and instead a traceback is always logged

I'm sorry, I don't think I understand the bug report. Are you just asking for https://docs.twistedmatrix.com/en/stable/api/twisted.web.http.Request.html#notifyFinish ? This is already on Klein's request, as it inherits from Twisted's.

When a client has already closed the connection, error handlers registered with `@klein.app.Klein(...).handle_errors()` do not get invoked, and instead a traceback is always logged

@Murtagy Ah, okay. I think I see the problem: you are saying that `@app.handle_errors(CancelledError)` *ought* to work. And yeah, I think I agree, although I think that as a *pattern*,...

When a client has already closed the connection, error handlers registered with `@klein.app.Klein(...).handle_errors()` do not get invoked, and instead a traceback is always logged

To be clear about the risk here: the goal of `handle_errors` is to allow you to translate known error conditions like an `HTTPError` from your application code, one that you...

When a client has already closed the connection, error handlers registered with `@klein.app.Klein(...).handle_errors()` do not get invoked, and instead a traceback is always logged

> So, we have caught CancelledError and re-raised with another home-written http exception (PriceNotFoundError) - it still hits the path of cancelled or finished request and writes the error log....

When a client has already closed the connection, error handlers registered with `@klein.app.Klein(...).handle_errors()` do not get invoked, and instead a traceback is always logged

So, I understand that this is creating a broken situation, but the *reason* that this behaves the way that it does is that we are expecting the error handlers to...

Recommendation at the bottom of help message is "too late"

This message could stand to be clearer. The idea is *supposed* to be that you need both the graphviz python package (which pip can install) and the actual underlying graphviz...