Glyph
Glyph
@taroved thanks so much for both reporting this and working on it.
Whew. OK, there are a couple of mixed-up issues here. - `HTTPFactory` really needs to delegate some of its logging responsibilities to a dedicated object, which can implement structured logging...
- why does `log` *silently* discard its logs?
Arguably one bug here is that pyobjc should pin *its* versions of recent releases to have a requires-python which would cause 3.8 to exclude them?
I would love to see this expressed as allowing a `None` mode to `__init__`, where we just skip setting the mode, because honestly that *ought* to have been the default;...
> Thank you both for the kind, swift and thoughtful feedback. It's maybe inconsistent - `unix.Port` and `listenUNIX` now have `mode = None`, but `UNIXServerEndpoint` still has `mode = 0o666`....
> e.g. `if self._socketIsOurFile` Yeah, I like this labeling of the relevant state 👍
Thank you for taking the time to create a minimal reproducer for this issue! My own interpretation here is that we should re-set this timeout every time the client empties...
> I am using a custom producers that writes the response in smaller chunks and updates the timeout. We could just do this internally. > I am not sure if...
@jpalus thanks for the report! It would be great to have an automated test to support this use-case. I don't think we have any tests that our documentation is generate-able...