Yihang "Corvo" Liu comments

Results 461 comments of


                                            Yihang "Corvo" Liu

MIP Ref Impl: bump zkapp state size to 32 - against dev

https://buildkite.com/o-1-labs-2/mina-end-to-end-nightlies/builds/3972

MIP Ref Impl: bump zkapp state size to 32 - against dev

!ci-nightly-me

MIP Ref Impl: Increase events&actions limit

!ci-build-me

MIP Ref Impl: Increase events&actions limit

!ci-nightly-me

Create the hard fork config automatically at the stop chain slot

I think I've requested to simplify 1439cea8d8497cb8158de956964819b1a3346778 in https://github.com/MinaProtocol/mina/pull/18061

Create the hard fork config automatically at the stop chain slot

I guess I can come back to this when we've merged https://github.com/MinaProtocol/mina/pull/18061

Create the hard fork config automatically at the stop chain slot

> A 2-node nightly integration test based on the existing hard fork test should also be added, but I've deferred that until the go hard fork test is sorted out....

Create the hard fork config automatically at the stop chain slot

Is it possible to seperate 1439cea8d8497cb8158de956964819b1a3346778 from the rest of the commits? I think it looks good except I feel back up is too verbose. Also I'm not confidence how...

Create the hard fork config automatically at the stop chain slot

Looks like except for > I changed the implementation here so that the config is now saved in auto-fork-config-mesa-{network_name} in the mina config directory. There's nothing new to review? I'm...

Create the hard fork config automatically at the stop chain slot

I suggest @cjjdespres and @georgeee reach a consensus on the directory hierarchy format though. I don't have a strong opinion here.