Francois Valdy

Results 92 comments of Francois Valdy

Code's open :smile: Feel free to fork, add this extra arg and report here. If the diff is simple enough I may consider merging it, but I'm really not sure....

ILRepack will only alter references for merged assemblies (in which case it supports merging only the highest version even if parts of the merge set reference older ones), so there's...

Hi, TL;DR: add a space in your `InternalsVisibleTo` declaration, needs to be `, PublicKey=...` Long(er) version, [this](https://github.com/gluck/il-repack/blob/master/ILRepack/Steps/AttributesRepackStep.cs#L91) highly NASA-grade-quality code expected the attribute to be specified using the standard way...

Done, I was zealous and included suggested #19 change at the same time (because a user could use this feature to revert/customize the naming behavior), lmk if you think I...

(note that I couldn't make it backward-compat because the check for duplicate `worker.worker.` would have to be done after webpack has resolved `chunkFilename` and I don't know how to hook...

Oh missed that, thanks. Though right now (correct me if I'm wrong), if I want to add this TypeRef cache on top of the regular MetadataImporter, I need to re-write...

That would work if the MetadataImporter called ImportReferences in its various Import methods, but it doesn't, it calls ImportType instead (private).

(I can make a PR to change only that, and will be able to manage the caching on my side then)

likely same issue I reported here: https://github.com/Figma-Linux/font-reader/issues/1

Hi, do you mean the build works fine without Gradle-properties-plugin applied ? It'd help if you were to provide a minimal build which fails, right now I can't see which...