Francois Valdy

Results 92 comments of Francois Valdy

Hi, what command/arguments do you pass to ILRepack ? also which version are you using ?

Thanks. Not yet tried, but vould be related to the logic [here](https://github.com/gluck/il-repack/blob/master/ILRepack/ReferenceFixator.cs#L102) if you wanna peek.

You may need to specify `/lib:`. I didn't think it was required if the assembly was in the same folder of one of the assemblies you're trying to merge, but...

It looks like it has never been the case, it could be implemented though. cf https://github.com/gluck/il-repack/blob/3829e3db36ffbf511fcec05316bbf36b33ce83fb/ILRepack/ILRepack.cs#L391

IIRC if you internalize types, it'l only merged the types which as used: e.g. `ILRepack A.dll B.dll /intern` will only expose A types and include B types used by A.

MahApps theme/accent seem to use an hardcoded reference to `MahApps.Metro` assembly, which ILRepack doesn't fix: https://github.com/batzen/MahApps.Metro/blob/master/src/MahApps.Metro/MahApps.Metro.Shared/ThemeManager/ThemeManager.cs#L71 There doesn't seem to be a way in MahApps to workaround that (beside crazy...

Missed the prefix indeed. Probably required to avoid conflicts but it will break for sure anytime someone loads a xaml resource dynamically. Option could be prefix only if conflict (won't...

Either way LGTM, the config way will be less "plug&play" (unlikely everybody using MahApps will understand why they need it), but also less magical 😄

Maybe yes, we're also a bit short on experience on WPF repacking to know what the right setting/behavior should be.