Gleb Petrikov
Gleb Petrikov
In my projects, as in many others, GitHub's language statistics give the impression that a significant portion of the code is written in Lua, especially if the project has multiple...
Hey @lildude, thanks a lot for the quick review! I totally understand the reasoning about build systems vs languages — Bazel → buildSystem, CMake → buildSystem, C++ → Lang, etc....
Thank you @lildude! I've made all the necessary edits: - Removed the heuristics section (not needed for filename-based detection) - Removed the interpreters section (premake files don't use shebangs) -...
Hey @lildude, just wanted to check if there’s anything else needed from my side to get this PR merged? All requested edits have been applied and real-world samples added. Thanks!
Hey @lildude, I think I've made all the required changes. I deleted premake4.lua because it's long outdated and hard to find a real example. I also added a real-world premake5.lua...
I hope I fixed it now?
It's in alphabetical order, isn't it? Something happened with my git, and the commits got mixed up for some reason. I rebased it and it seems to have fixed everything.
Look again, when you looked there, the commits were mixed up (and first five commits ended up at the top in reverse order and broke everything). It should be correct...
Ready for review! I've removed `premake4.lua` because it is outdated. I’ve also added a real-world `premake5.lua` example with source code and a license, and updated `vendor/README.md` using a script. Everything...