Gloria Zhao

Results 38 issues of Gloria Zhao

Originally motivated by #29019, which reverts back to having `requestMempoolTransactions` emit `transactionAddedToMempool` in `mapTx` default order instead of `GetSortedDepthAndScore` order. It's important that these notifications happen in topological order, otherwise...

Tests

Backports for 26.x. Includes: - 453b481 from #28391 - #29179 - #29200 - #29227 - #28791 - #29127

Backport
CI failed

The `-maxtxfee` (which is put into `m_default_max_tx_fee`) is documented as "the maximum total fees to use in a single wallet transaction" https://github.com/bitcoin/bitcoin/blob/632a2bb731804dffe52bd4cbd90bfee352d25ede/src/wallet/init.cpp#L63 This seems true in many instances when we...

Wallet

Motivated by #29193. Currently, we only log something (non-debug) when we fail to load the file and at the end of importing all the transactions. That means it's hard to...

Mempool
Utils/log/libs
Needs backport (26.x)

This issue will be edited frequently to reflect the current status of the project. ### What is ready for review now? :point_down: :point_down: :point_down: Nothing right now :point_up: :point_up: :point_up:...

Feature
Brainstorming
TX fees and policy
P2P

Built on top of #28948 as a demonstration/proposal of another nice feature you can do when you only need to deal with 1p1c packages. When we receive a v3 transaction...

TX fees and policy

This PR contains changes to `TxOrphanage` needed for package relay stuff. See #27463 for project tracking and #28031 for how this code is used. Separating this PR was suggested in...

Needs rebase

https://cirrus-ci.com/task/5616118744743936 ``` test 2024-02-06T11:27:14.369000Z TestFramework (ERROR): Assertion failed Traceback (most recent call last): File "/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 131, in main self.run_test() File "/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/wallet_reorgsrestore.py", line 75, in run_test assert_equal(conflicted["confirmations"], -9) File "/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py",...

Wallet
Tests
CI failed

Addresses final comments from #28948: - thread at https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1483245289, using https://github.com/ismaelsadeeq/bitcoin/commit/87fc7f0a8d8ad1fc2af60ee6cc678df5e6fb01dd with some modifications - https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1483769698 - https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1483776227 - https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1484427635 - https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1484467280 - https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1484531064 - https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1484992098 - https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1484992336 - https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1484994642

Refactoring
Docs
Tests

Final changes to tag a 26.1rc1. Bumps version numbers, man pages, adds release notes etc.

Backport
CI failed