Gloria Zhao
Gloria Zhao
> I think at a high level, the "package relay" part looks like: Yes, that is how I think of it. > Particularly if https://github.com/bitcoin/bitcoin/pull/26933 is applied, is there any...
> If the state-of-art implementation of BIP331 can be linked here or in the BIP (Like there is https://github.com/glozow/bitcoin/pull/8 and https://github.com/glozow/bitcoin/pull/9) ? > From a reviewer perspective, ideally it’s better...
Status update: I've put all the p2p PRs in draft to focus on getting the mempool/validation things done (I was struggling to context-switch and iterate quickly with the 5+ PRs)....
There have been discussions on what package validation and RBF rules will look like in a post-cluster mempool world. #26711 either doesn't work with cluster mempool or should not be...
> plain `%.3f` will output 0.000 for 0.0009, don't think that's the right thing to do, should ceil or round before output then. Why? "It took less than 1ms" should...
> > lgtm ACK [c819a83](https://github.com/bitcoin/bitcoin/commit/c819a83b4d83413a31323c1304664ee4c228ca29). can you update the PR description? > > Updated. Are you sure the 'before" is accurate?
Let me know if I should reopen this issue?
> > I'm not sure if we try to keep strings for `reject-reason` stable at all. > > You mean like how block reject reasons are defined [in BIP22?](https://github.com/bitcoin/bips/blob/master/bip-0022.mediawiki#user-content-Appendix_Example_Rejection_Reasons) Yeah...
> alternative log lines are a bit noisy, but understandable and I have no good suggestions that reduce that much > I'm not sure how important it is to return...
> So unless my understanding is incorrect all major Lightning implementations have failed to implement CPFP carve-out It seems your understanding is incorrect, given https://github.com/bitcoin/bitcoin/pull/29306#issuecomment-1963777819 and https://github.com/bitcoin/bitcoin/issues/29319#issuecomment-1967555969 > can you...