Gloria Zhao

Results 188 comments of Gloria Zhao

> My initial attempt at this modified `getrawmempool` to > > * take a `start_sequence` to allow for filtering, and > > * adding the txdata (inputs outpoints + outputs...

Hard to guess without logs (which would tell us why transactions failed). How much time elapsed between saving the mempool.dat and loading it? Mempool transactions that had confirmed during that...

@deyw-bit can you tell us the specs of your machine?

@deyw-bit How long did IBD take on your machine?

+1 @dev7ba there's not much to go on without logs. Maybe consider updating your software, and open another report with more information if it happens again?

> transactions with mempool dependencies don't get considered for fee estimation. Ah, my bad! Seems like we're definitely underestimating in CPFP situations right now, then, since we include the parents...

> I have historical snapshots and would be happy to help run the test. Although, since running the test is not trivial, I wouldn't make a blocker for the PR....

@darosior thanks for the data! The proportion of transactions with descendants seems pretty high, so my comment about ignoring stuff with descendants is probably not a good idea.

> Idk why @DrahdBot did not update but this PR conflicts with https://github.com/bitcoin/bitcoin/pull/28368 DrahtBot doesn't detect silent merge conflicts afaik. But yeah, this PR uses the vector of entries to...

fixed commit messages.