Grzegorz Liter

Results 10 comments of Grzegorz Liter

Ad 1. That definitely be an improvment. It could be even made to set it only when executing the main statatmenet I would add approach 3. to allow pipeline configuration...

This is also related to https://github.com/getindata/dbt-flink-adapter/issues/35 and not supporting catalogs.

For this task I would go for something much simpler. Just use standard mock in place of a Flink SQL client (alternativly http mock) so we can do some tests...

Yes, I just wonder about naming and function calls. Because `create_session` is something that adapter does internally. How would you use it in context of `tests/functional/adapter/test_seeds.py` where we are creating...

I see that we have sometimes quotes inside macros and sometimes are taken from function that uses QuotePolicy. We should make approach uniform across all places.

In the UI you should have more than one job. Could you post Flink logs as well? If you have run with `docker-compose up` please take a look at console...

@cmroche sorry for late response. There is really nothing to share. It does respond to scan package with: ``` {"t":"dev","cid":"","bc":"00000000000000000000000000000000","brand":"gree","catalog":"gree","mac":"","mid":"10001","model":"gree","name":"","lock":0,"series":"gree","vender":"1","ver":"V3.2.M","hid":"362001068254+U-4MWB65VRV2.08.bin","ModelType":"16752730"} ``` but when you send the bind package there is...

I would prefer the code be structured a bit differently, mainly by not creating ArrayList just to be passed as parameter and return stream instead in `addSplitsForPath` but it have...