Gabriel Lichtenstein

Results 9 comments of Gabriel Lichtenstein

Hi, same issue here, currently I am working in a fix, I still need to update the nf-core tests and pass them, hopefully soon it will succeed and be available...

--- **Question for Reviewers about setting up a test for the PR:** In our in-house testing using BCLConvert, we have a `SampleSheet.csv` where one of the samples has wrong barcodes...

> Thanks for the PR! > > Gonna wait for @matthdsm on this one. > > In the meantime could you squash some of the commits? There's a lot of...

> @glichtenstein about the test data, yes I think it would make a lot of sense to have a samplesheet with faulty barcodes. Maybe it would be best to just...

> I think it's great to be able to complete the pipeline even with faulty barcodes! However, sometimes we might want the pipeline to crash to avoid risking this issue...

@Aratz I have opened a PR in [modules](https://github.com/nf-core/modules/pull/4842) 🤞

> Thanks for the PR! > > Gonna wait for @matthdsm on this one. > > In the meantime could you squash some of the commits? There's a lot of...

Closing this PR, it was opened on nf-core/modules instead: https://github.com/nf-core/modules/pull/4842