Glenn Matthews

Results 300 comments of Glenn Matthews
trafficstars

Thus far in some manual testing I'm unable to trigger the GitPython memory leak. Even after re-cloning a repository 1000 times, or cloning 100 separate repos, there are no extraneous...

Hi @nathanielfernandez, were you able to make any progress on trying this out?

It would be good for pynautobot to have an option to specify custom query parameters in order to support this as well as other such use cases - for example...

Dependabot is now reporting a need to update to mistune 2.0.3 or later due to a [security vulnerability](https://nvd.nist.gov/vuln/detail/CVE-2022-34749), for what it's worth.

Is there a reason `peering_add.html` can't or shouldn't inherit from `generic/object_create.html` instead?

Do these even need to be database fields or can they just be computed `@property` items?

- I'd propose `RoutingInstanceTemplate` rather than `RoutingInstanceType` as a clearer name. - Will probably need `PeerGroupTemplate`, `AddressFamilyTemplate`, and `PeerGroupAddressFamilyTemplate` models that can be created as children of a `RoutingInstanceTemplate` in...

The general pattern I'd go with would be to have a base Exception class (`SchemaEnforcerException` or similar) that all case-specific exceptions could inherit from, and then your main CLI function(s)...

I'm not as concerned as @itdependsnetworks about specifically preserving exact character counts, but I do agree that it would be good to keep some uniqueness across different IPs rather than...

Optionally could add an entirely new field, `full_message` or something to the `Maintenance` model, if we want to keep the current behavior of `summary` as an extremely brief excerpt.