Glenn Matthews

Results 301 comments of Glenn Matthews
trafficstars

I think it would be more appropriate to actually make this a general fix, likely here: https://github.com/nautobot/nautobot/blob/v1.6.19/nautobot/core/api/views.py#L198-L204

Let's use this bug fix as an opportunity to revisit how that block of code in `utils/filtering.py` works - this isn't the first time we've had an error like this.

Maybe we could add a test to the generic list view testing to specifically test filtered list view, if we don't already have something appropriate? Either way would like to...

Generic view tests don't catch this because the only filter they test by default is the `id` filter, and the dynamic filter form only calls `get_filterset_parameter_form_field()` for filters that are...

Would be good to retest and confirm whether this is still an issue after the Job/Git fixes made in v2.2.3 (i.e. #5586).

Reading between the lines of the original submission, the error is referencing job `ot_config_firewall.FirewallConfiguration` but the screenshot is showing job `alethia_git_repository.jobs.config_ot_firewall.FirewallConfiguration`. I therefore wonder if the underlying issue here is...

Good catch. Probably it would be best to default the check to the path `/tmp/nautobot_celery_beat_heartbeat` if the variable is unset, rather than failing.

@lampwins - add this to the UI Python Framework epic?

Part of the issue at present is that the upstream monitor CI doesn't actually fail when tests fail; this was done to prevent failures in one App from causing the...

As far as I understand the original issue, the current biggest problem is https://github.com/gitpython-developers/GitPython/issues/718, which may be mitigated by ensuring that we explicitly delete any `git.Repo` objects when done with...