Glenn Matthews
Glenn Matthews
I suspect the issue is [here](https://github.com/nautobot/nautobot/blob/develop/nautobot/extras/api/serializers.py#L132): ```python def get_notes_url(self, instance): notes_url = get_route_for_model(instance, "notes", api=True) return reverse(notes_url, args=[instance.id], request=self.context["request"]) ``` We probably need a `try... except NoReverseMatch` wrapper around that...
Thanks for the report! I must be missing some nuance of the code, because this *should* be working correctly with the [`if not delete:` check](https://github.com/nautobot/nautobot/blob/develop/nautobot/extras/datasources/git.py#L916) preventing the jobs from being...
You're right, my mistake. I was thinking of the [`if "extras.configcontextschema" in repository_record.provided_contents and not delete:` pattern](https://github.com/nautobot/nautobot/blob/v1.4.5/nautobot/extras/datasources/git.py#L762), and as you noted the Job case is missing a `if "extras.job" in...
I'd love to get rid of the bespoke logging API for Jobs and just let them use stdlib `logging` in all cases.
That would be the tradeoff. Unless we want to use something like `structlog` - I do *not* want to go in the direction of having Nautobot be responsible for parsing...
Worth considering as part of #765
Need to consider how this intersects with https://github.com/nautobot/nautobot/issues/765#issuecomment-1272388605 - the request there as I understand it would be to also have an option for jobs to *not* capture logs (or...
Thanks for the report! FWIW, the NetBox maintainers have previously asserted that this is "by design" - see https://github.com/netbox-community/netbox/issues/4429, https://github.com/netbox-community/netbox/issues/4656, https://github.com/netbox-community/netbox/issues/4677, https://github.com/netbox-community/netbox/issues/5270, etc. That said, we may well want to...
Related: #2653
Huh. Wonder why that didn't happen when I ran tests locally with 3.12. Investigating.