Glenn Matthews

Results 285 comments of Glenn Matthews
trafficstars

Can we also make this more robust in general so that we don't hit this same issue in the future if (heaven forbid) we somehow end up with a plugin...

Ah - this is actually coming from https://github.com/nautobot/nautobot/blob/develop/nautobot/extras/jobs.py#L1243. Since Jobs can have a slug [up to 320 characters in the worst case](https://github.com/nautobot/nautobot/blob/develop/nautobot/extras/constants.py#L39), we definitely need some truncation logic and/or to...

Besides the changelog fragment and resolving the merge conflict, is this ready to go?

Thanks for the request. I think we're already tracking and considering this feature under #889?

> ## `pyproject.toml` > > There is a rather large list of disabled rules for PyLint that we should revisit. I did some analysis of these in https://github.com/nautobot/nautobot/issues/2292#issuecomment-1235666827 > `**nautobot.utilities.testing.views.APIViewTestCase**`...

> > How to address the case of "This is a piece of hardware sitting on a shelf that hasn't yet been installed" then? What should the name of such...

`check-schema` is failing because of https://github.com/tfranzel/drf-spectacular/issues/816, fixed in 0.24.1 and later. Need to update the minimum drf-spectacular version in concert with this change.

Thanks for the report. Looks like a code bug rather than a test issue, just to be clear - we shouldn't be causing a 500 error.