Glenn Jacobs

Results 195 comments of Glenn Jacobs

@alecritson I think this is probably needed, however, do we need to consider any updates to the Orders side of things?

> @wychoong i would be open to that. > > @glennjacobs ? Yes, I'm open to that. It's just a case of finding a suitable function name for it.

Let's go with `LunarPanel::extensions(` + `->extensions(` approach. This shortens `registerExtension` and is in line with how Filament name things.

We are aware of this and the new model extending will resolve this in v1.0.

The idea is to set the Meilisearch index mappings based upon the attribute data configuration.

Why do we need this? Lunar uses it for images, hence the collection name is called `images`.

@alecritson can I have your opinion, please? Things to consider... - Will this not break the admin panel, unless we introduce the config there also? - I don't think we...

> @glennjacobs Doesn't look like we've hit every instance of `SpatieMediaLibraryImageColumn` when updating the `collection` method to config. Should be sorted.

> This is ready for review. Should it still target the 0.7 branch? As this isn't a bug fix, it should really target `0.8` please.