lunar icon indicating copy to clipboard operation
lunar copied to clipboard

Add base `LunarException` and other updates to exceptions

Open adevade opened this issue 1 year ago • 6 comments

Added a base LunarException class (that extends the standard Exception class) adding more flexibility for users. All Lunar exceptions now extend from that instead.


Added types for method arguments where missing (base Cart and Fieldtype exceptions).


Added a missing translation in the base CartException class.


Formatted according to most empty Laravel framework exceptions (ex MathException.php, DeadlockException.php)


Feel free to request or push changes 👍

adevade avatar Nov 30 '23 22:11 adevade

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 7:04pm

vercel[bot] avatar Nov 30 '23 22:11 vercel[bot]

This is ready for review. Should it still target the 0.7 branch?

adevade avatar Dec 20 '23 15:12 adevade

This is ready for review. Should it still target the 0.7 branch?

As this isn't a bug fix, it should really target 0.8 please.

glennjacobs avatar Dec 22 '23 10:12 glennjacobs

Switched to 0.8 branch and pulled in latest changes 👍

adevade avatar Dec 22 '23 13:12 adevade

Fixed formatting conflicts

adevade avatar Jan 25 '24 13:01 adevade

PHP 8.3 added more granular exceptions and errors in a similar fashion: php.watch/versions/8.3/datetime-exceptions

adevade avatar Feb 14 '24 13:02 adevade

Should I retarget this to 1.x instead and fix potential merge conflicts? Just want to help out! 😊 I know that you guys have a lot on your plates with the alpha releases. Keep up the good work! 👍

adevade avatar Apr 23 '24 08:04 adevade

Should I retarget this to 1.x instead and fix potential merge conflicts? Just want to help out! 😊 I know that you guys have a lot on your plates with the alpha releases. Keep up the good work! 👍

No it's fine. We've been a little off the radar as we've been "dog flooding" Lunar 1.x with our projects to ensure we're happy with it. We intend to merge all the 0.8 PRs soon (assuming they're good) and then merge that back into 1.x.

glennjacobs avatar Apr 23 '24 08:04 glennjacobs

Thanks @adevade this is a good helpful addition.

glennjacobs avatar May 06 '24 19:05 glennjacobs