lunar
lunar copied to clipboard
Add base `LunarException` and other updates to exceptions
Added a base LunarException
class (that extends the standard Exception
class) adding more flexibility for users.
All Lunar exceptions now extend from that instead.
Added types for method arguments where missing (base Cart and Fieldtype exceptions).
Added a missing translation in the base CartException
class.
Formatted according to most empty Laravel framework exceptions (ex MathException.php, DeadlockException.php)
Feel free to request or push changes 👍
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
lunar-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 6, 2024 7:04pm |
This is ready for review. Should it still target the 0.7 branch?
This is ready for review. Should it still target the 0.7 branch?
As this isn't a bug fix, it should really target 0.8
please.
Switched to 0.8
branch and pulled in latest changes 👍
Fixed formatting conflicts
PHP 8.3 added more granular exceptions and errors in a similar fashion: php.watch/versions/8.3/datetime-exceptions
Should I retarget this to 1.x
instead and fix potential merge conflicts? Just want to help out! 😊 I know that you guys have a lot on your plates with the alpha releases. Keep up the good work! 👍
Should I retarget this to
1.x
instead and fix potential merge conflicts? Just want to help out! 😊 I know that you guys have a lot on your plates with the alpha releases. Keep up the good work! 👍
No it's fine. We've been a little off the radar as we've been "dog flooding" Lunar 1.x with our projects to ensure we're happy with it. We intend to merge all the 0.8 PRs soon (assuming they're good) and then merge that back into 1.x.
Thanks @adevade this is a good helpful addition.