Glen

Results 238 comments of Glen

I hope that the TSC will consider my suggestion of prefixing comment directives, in order to avoid ambiguity. `exported` -> `eslint-exported` `globals` -> `eslint-globals` `global` -> `eslint-global` `eslint` -> `eslint-rules`...

Did you try `iframeLoadMode: 1`? https://github.com/aFarkas/lazysizes/blob/1523a4ff4579e170355c7607f445689b43229caf/src/lazysizes-core.js#L479-L488

@jasonmalinowski Apologies for the ping, but is there any update on this? It's painful working with source generators in VS Code.

@JoeRobich When will the fix for #1800 be available in the SDK? **Edit:** See also https://github.com/dotnet/sdk/issues/32598.

@clairernovotny If the conflicts were resolved, would this PR be accepted?

@SimonCropp - The IEC Standard has been adopted by the IEEE, EU, ISO, and NIST, since 2009. - `Kilo-` literally means "thousand", `Mega-` is used in [many places](https://en.wikipedia.org/wiki/Mega-#Common_examples_of_usage) to refer...

> If we want to change the behaviour, we need to bump the major version. Absolutely. > I still suggest we have a strategy in there that allows people to...

> if you want the old behavior change usages of Kilobytes to Kibibytes They may still want it to show "kilobytes" and not "kibibytes" in certain cases: > The binary...

Are `GetLargestWholeNumberSymbol` and `GetLargestWholeNumberFullWord` even handled in that PR? I think 1,024 bytes will still return `KB`. If the code is `(1024).Kilobytes().Humanize()`, how would you know whether to output `1...

But what does this output? ```cs var maxFileSize = (10).Kibibytes(); maxFileSize.LargestWholeNumberSymbol; // ? ``` I'd expect to see `KiB`, but I think it'll be `KB`?