vscode-csharp icon indicating copy to clipboard operation
vscode-csharp copied to clipboard

Support opening of source-generated files over LSP

Open jasonmalinowski opened this issue 1 year ago • 11 comments

This depends on https://github.com/dotnet/roslyn/pull/68771 for the server-side piece. But, if you don't have the server side piece, we won't return a URI that will trigger this code, so it's fine to have it in now.

jasonmalinowski avatar Jun 24 '23 01:06 jasonmalinowski

Will review tomorrow!

CyrusNajmabadi avatar Jul 10 '23 21:07 CyrusNajmabadi

Any chance this will get merged soon?

moander avatar Oct 11 '23 12:10 moander

@moander Hopefully in a week or two; unfortunately my attention is in a different direction for the rest of this week...

jasonmalinowski avatar Oct 11 '23 17:10 jasonmalinowski

I thought I'd leave a comment here thanking you for the great work, and also echoing the ask to merge this soon. This is making development in projects with source generated code quite difficult. Because as soon as you hit this bug the best thing to do is to restart VSCode. Thanks again

pragone avatar Oct 11 '23 23:10 pragone

@jasonmalinowski Apologies for the ping, but is there any update on this? It's painful working with source generators in VS Code.

glen-84 avatar Nov 29 '23 14:11 glen-84

@glen-84 Thanks for the friendly ping! Hopefully can get this in a week or two -- I recognize that's what I said a few weeks go but that prior work turned into more than expected. But that work is now cleared so this is towards the top.

jasonmalinowski avatar Nov 29 '23 20:11 jasonmalinowski

@jasonmalinowski any updates on this one? I'm really looking forward to this patch. Have a nice weekend! :)

moander avatar Feb 16 '24 15:02 moander

@moander I think I'm going to have the Roslyn side of the change today, assuming no other random fires come up. (They've been coming up a lot recently. 😢 )

jasonmalinowski avatar Feb 16 '24 18:02 jasonmalinowski

Bump on this; I believe @jasonmalinowski has gone on leave. Are we able to reassign?

jacobjmarks avatar Apr 26 '24 01:04 jacobjmarks