Gregory Lemieux

Results 157 comments of Gregory Lemieux

> I think for our testing every change should be attributable to a specific Pull Request so the parameter file used by a test really should not be changing on...

> I am assuming the cdl file is a part of the FATES repo and any changes to it will happen through a PR updating the FATES api (correct me...

Started up a discussion in the "feature request" section: https://github.com/E3SM-Project/E3SM/discussions/6681

> This update provides FATES with insight into the nutrient supplementation modes. This work is driven by changes per [NGEET/fates#1353](https://github.com/NGEET/fates/pull/1353) and as such should be coordinated with that pull request....

@rgknox I found a circular dependency that's going to require a little more work to untangle. So please hold on the review. @rljacob would you change this back to a...

I'm also seeing another test fail: `not ok 1202 - inventoryfileDNE`. It looks like maybe this is failing because there are two unit test cases with the same name: https://github.com/ESCOMP/CTSM/blob/37204fbc251cd3077dc3751628b75c25d95cf1a0/bld/unit_testers/build-namelist_test.pl#L1133-L1148...

Running the fates regression tests on this is resulting in RUN failures with a floating point exception. The truncated stack trace is below. Folder of tests is here: `/glade/u/home/glemieux/scratch/ctsm-tests/tests_bedrock-fates-retest` ```...

Printing out the variables on that line during runtime shows that `rootr_patch` is `NaN` for some patch indices, so this likely is some sort of initialization issue.

Check to see if https://github.com/NGEET/fates/issues/732 is addressed by this.