David Glasser comments

Results 468 comments of


                                            David Glasser

Graph Admin Token Unexpectedly "malformed" When Attempting a Rover Subgraph Publish

Duplicate of #1171

docs: new path for useServer v6 and up

Hi, are you sure that's the only change? In addition to another import in the same file, the code shows a few calls to `useServer` with methods whose options may...

`accept: application/graphql-response+json` does not actually return `content-type: application/graphql-response+json`

Note that a good solution here will implement the `accept` algorithm correctly, including `q` values. The mediatype crate we use does not implement the algorithm; it only even added the...

Allow passing http2 server to ApolloServerPluginDrainHttpServer

That seems like a reasonable PR. It would definitely need tests because it's easy to believe that the shutdown/drain behavior differs between these two classes!

Allow plain JS object repeated fields to use toArray() method

I'm noticing that this repository seems to be back under development! Is there any interest in taking this PR (if I rebase it)? We've been using it in [our fork](https://www.npmjs.com/package/@apollo/protobufjs).

Allow plain JS object repeated fields to use toArray() method

4.5 years later I'm happy to reiterate my offer to rebase the PR if there's any chance of it being merged. The Apollo Server project had to fork protobuf.js many...

Support the equivalent of spec.source.helm.ignoreMissingValueFiles

Actually, hmm — maybe `LOVELY_HELM_MERGE` is what I'm looking for for the first bullet point. So maybe this is just a request for an implementation of ignoreMissingValueFiles.

Shell Completions!

Note that `clap_complete` now exists, which makes it pretty easy to add a subcommand to rover so that people can add `source "$(rover completions --shell bash)"` or whatever to their...