Gary Katsevman

Results 538 comments of Gary Katsevman

Also, we can transcode oceans into hls and dash and use that as defaults as well.

should it be removed or maybe inverted to say that very old versions of vjs included it? I'm good with either.

You're 100% right, we should make sure our site is accessible and not just the player. Would you be able to do a quick pass? Otherwise, we'll get to it...

Are NOTEs not supported? I'd expect 'em to get ignored and everything else to parse https://github.com/videojs/vtt.js/blob/0.15.x/lib/vtt.js#L1243-L1248 Have a minimal live example?

This PR implements region support. It stays within the framework of the current API, which makes it a bit annoying. I think processCues probably needs a refactor for how it...

This still needs a couple of changes, making sure that if scroll:up isn't set, it doesn't scroll but just pops. also, verifying that regular captions are still working fine.

A better API can wait for a complete overhaul.

This is a breaking change since it requires *not* clearing the display each tick like Video.js has been doing previously.

Unfortunately, the test scripts are broken and can only be run on node 0.10. I've been basically testing things manually as things are changing. I hope to revamp the test...

You're welcome. I'm actually in the middle of a refactor to move a bunch of things into separate files so it's a bit easier to work with this repo. Hopefully,...