George Kalpakas comments

Results 148 comments of


                                            George Kalpakas

ngSanitize 1.5.0 triggers Internet Explorer memory leak

Not sure how using a 3rd party lib can be considered "not using a 3rd party lib". It is not an issue of terminology. The problem with issues appearing only...

remove 'replace' property from tabs directive example on home page

While it's not going anywhere in the foreseeable future, it would be nice (imo) to not promote it (by featuring it on examples). If anyone is up for a PR,...

Feature Request: angular.decorator as companion to angular.component

`angular.decorator()` is already taken, so need some other name :D

install failed

It seems that `bower install` fails. There can be several reasons about it and it is not clear based on the log. Just in case, check out "Firewall/Proxy issues" in...

[IE11]: Checkbox state and ng-model binding not in sync on calling preventDefault inside click handler

Thx for reporting the issue, @Amrender-Singh. I am not sure this is something that would need to be fixed in AngularJS (AngularJS uses the `change` event - it is expected...

$animateCss used on a directive that uses a templateUrl breaks

@michi88, your issue is the same as #15510 (and might be slightly different (or a subset) of that from the OP). [This comment][1] applies to you too. **tl;dr** #15514 would...

$animateCss used on a directive that uses a templateUrl breaks

> That said, I think there might be another (possibly similar) bug related to staggering The issue is actually related to `$animateCss` (regardless of staggering) and is identical in nature...

Calling history.replaceState in data URI of an iframe causes error in Firefox and Edge

Thx for stepping up, @Sayan-dev :+1: AngularJS (1.x) is in LTS mode, so I am afraid we are no longer accepting changes that are not critical bug fixes into this...

log usable error on unhandled non error rejections Fixes #15816

We need tests.

log usable error on unhandled non error rejections Fixes #15816

I never look at the implementation if there are no tests 😛 If we can have the feature in a consistent way and without hurting working usecases, it is fine...