angularjs.org icon indicating copy to clipboard operation
angularjs.org copied to clipboard
verified publisher icon angular

remove 'replace' property from tabs directive example on home page

Open MokoJumbie opened this issue 10 years ago • 2 comments

Considering that 'replace' is deprecated, should the use of it still be encouraged by one of the first directive code examples newcomers will see on the site?

MokoJumbie avatar Feb 04 '15 17:02 MokoJumbie

I've been looking into this but I'm not so sure this is an issue. Even though it is currently deprecated it will not be removed until v2.0 according to the current docs. In addition, @caitp mentioned in angular/angular.js@eec6394a342fb92fba5270eee11c83f1d895e9fb that

replace: true isn't being removed. You can be pretty certain of that, like as cute as it is for us to say it's deprecated, it's not going anywhere.

On the other hand, if this is something that needs resolved I would be interested in looking in to it.

JordanMajd avatar Sep 05 '15 08:09 JordanMajd

While it's not going anywhere in the foreseeable future, it would be nice (imo) to not promote it (by featuring it on examples).

If anyone is up for a PR, we could consider removing it (I guess).

gkalpak avatar Sep 05 '15 11:09 gkalpak