George Kalpakas comments

Results 148 comments of


                                            George Kalpakas

feat(ngHref): bind href attribute to ng-href attribute in case SVG el…

I think we will need a lot more changes (e.g. [here][1], [here][2], [here][3] and probably elsewhere) and more tests and security reviews. TBH, I am not sure it is worth...

feat(ngRoute): screening colon in given path

According to [RFC2396](http://tools.ietf.org/html/rfc2396#appendix-A) - although reserved - `:` is allowed (unescaped) in fragments, which is what we use when in HashBang mode (currently the default). Considering that (and the fact...

Inactive/Dead?

I am not sure what the state/purpose of this project is, but there is also the [quickstart][1] project, which is more up-to-date and also used by the official docs (so...

code examples: Removing text-shadow on the AngularJS bits will improve readability

I think the styles should be changed wherever that light blue background is applied (i.e. [docs.css][1] afaict). I would also experiment with a lighter shade of blue (instead of or...

expand but not collapse

What item are you referring to?

Angular js batarang enable option is disabled

I can't reproduce this (Chrome 64, Windows 10) 😕 What version of Batarang have you installed?

wildcard redirects not working from 'firebase serve'

Still an issue on `[email protected]` 😞

wildcard redirects not working from 'firebase serve'

This seems to work with `[email protected]` (with `[email protected]`) - possibly earlier versions too. ## However, there seems to be a couple of limitations/deviations from the actual server (used for deployed...