angular.js icon indicating copy to clipboard operation
angular.js copied to clipboard

feat(ngHref): bind href attribute to ng-href attribute in case SVG el…

Open m-amr opened this issue 8 years ago • 1 comments

…ement

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Feature that solve https://github.com/angular/angular.js/issues/15618

What is the current behavior? (You can also link to an open issue here) href attribute doesn't bind to ng-href in case of SVG element

What is the new behavior (if this is a feature change)? href attribute binds to ng-href in case of SVG element

Does this PR introduce a breaking change? No

Please check if the PR fulfills these requirements

  • [x] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been added / updated (for bug fixes / features)

Other information:

m-amr avatar Feb 09 '17 04:02 m-amr

I think we will need a lot more changes (e.g. here, here, here and probably elsewhere) and more tests and security reviews. TBH, I am not sure it is worth it at this point (until the spec is finallized and implemented by browsers).

gkalpak avatar Feb 09 '17 10:02 gkalpak