Geoffrey Jacoby

Results 31 comments of Geoffrey Jacoby

@hnguyen08 - while your changes for the table names are good changes, since you're only making them to one branch they'll make it harder to maintain the code going forward....

@richardantal - I see that I missed a bunch of discussion back in PHOENIX-6486, but I'm not yet convinced that having an equivalent to GJChronology / BritishCutoverChronology is the right...

Thanks @stoty , I hadn't realized that the Java 7 (and before) GregorianCalendar had an internal cutover similar to GJChronology. So for me then the question is what version is...

@vmeka2020 - are you still interested in getting this patch into Phoenix 5.2? Looks like this PR needs to be rebased before we can see if the tests are currently...

@stoty - @apurtell is going to be unavailable for a couple of weeks, so I went ahead and fixed the NoLookbackMutableIndexExtendedIT and NoTransactionAvailableProvider nits.

I can't reproduce the test failure in TenantViewOperationsWorkloadIT either in the master branch or Andrew's feature branch. I've kicked off a new CI build to see if it recurs. If...

@dbwong - looks like we're getting a build failure from undeclared dependencies: [INFO] --- maven-dependency-plugin:3.1.1:analyze-only (enforce-dependencies) @ phoenix-core --- [WARNING] Used undeclared dependencies found: [WARNING] org.apache.hadoop:hadoop-hdfs:jar:3.1.4:compile [WARNING] com.sun.xml.bind:jaxb-impl:jar:2.2.3-1:compile [WARNING] org.apache.curator:curator-client:jar:4.2.0:compile...

@dbwong - Thanks, I think you've addressed all my previous comments. However, it looks like the recent pom changes to address the implicit dependencies caused a lot of build errors...

I think if the build failures are addressed and we get a clean test run (not counting the refCount flappers I'm addressing on another JIRA) this should be good to...

@dbwong - the last commits did fix the build errors, but the ParallelPhoenixUtilTest getAnyOfNonExceptionallyTimeoutTest is failing because it's not actually timing out. Since this is a unit test failure, the...