Giuseppe Scrivano

Results 326 comments of Giuseppe Scrivano

> That said, wouldn't we still de duplicating the files in the OCI layer tarballs, making e.g. downloads larger? the downside is when you pull an image to vfs, it...

> > > That said, wouldn't we still de duplicating the files in the OCI layer tarballs, making e.g. downloads larger? > > > > > > the downside is...

I've addressed some of your comments, but I leave this still marked as Draft as I want to do another pass

I won't deal with rebases trying to keep this PR alive for now. I'll reopen it once it is clear we want it and can get reviewed

I don't think we use `/etc/containers/storage.conf` for rootless, except for `rootless_storage_path`. I am not sure whether we should do that, the storage configuration can be very different for root and...

> @giuseppe We would like to avoid user-specific configurations. Usecase here to configure sane global defaults to ensure consistent/reproducible behavior for all users across shared servers. is there any reason...

I agree, this part of the code is quite messy and hard to follow

could we write these files before the image is recorded? We'd still need to have some kind of GC if these files are written but the image wasn't recorded. Another...

> As for the locking, is that so infeasible? It probably is with the current API, but a > `CreateImageAtomically(expectedID, topLayer, bigData map[string][]byte], names []string)` seems plausible at a first...