Giuseppe Scrivano

Results 326 comments of Giuseppe Scrivano

we do a few lazy loading of files in containers/storage. That would be affected if we join a different mount namespace. Do you need to access the storage on the...

> I vendored in your PR and ran podman tests. [tons of failures, all in seccomp](https://github.com/containers/podman/pull/22425/checks?check_run_id=24464599416), all timeouts. Too many failures to be coincidence, I think. sorry for wasting your...

ah no, this is another issue in the PR. I've fixed it now. It happens only when the registry rejects the range request, and I am going to debug now...

> ah no, this is another issue in the PR. I've fixed it now. It happens only when the registry rejects the range request, and I am going to debug...

pushed a new version that addresses all the comments.

@mohanboddu should the jira label create automatically the issue?

I'd like to get this into the next release, can we move it forward?

> Just to unblock progress, not a careful review I’m afraid. Thanks. Fixed the comments and pushed a new version

@mtrmac thanks for the review, I've opened a PR: https://github.com/containers/storage/pull/1926

we should not be so aggressive to cleanup the staging directory: https://github.com/containers/storage/blob/3cbd3c6fcd26cc961c1b462575aa1f0c597a24b1/drivers/overlay/overlay.go#L883 I am not sure yet how to address it, I'll keep working on this