github2023spring

Results 8 comments of github2023spring
trafficstars

seems like this issue can be closed with #246?

Currently, is there a way to measure the latency of an upstream request, and instrument it through metrics?

For update the request header, can we also do that in `request_body_filter`? or we have to do it in `upstream_request_filter`? If it is latter, It seems like `upstream_request_filter` is executed...

I think the `requestBody` needs to be read in `async fn request_body_filter(` method. https://github.com/cloudflare/pingora/blob/main/pingora-proxy/src/proxy_trait.rs#L94

Hmm, I tried to buffer the request into the `CTX`, and then set back in the `request_body_filter`, but it does not work.

``` fn check_login(req: &pingora_http::RequestHeader) -> bool { // implement you logic check logic here req.headers.get("Authorization").map(|v| v.as_bytes()) == Some(b"password") } #[derive(Deserialize, Debug)] struct RequestBody { argument: Option, } #[derive(Debug)] pub struct...

Will we add back the support for CJS? Thank you!