Jin comments

Results 16 comments of

Jin

Overflow in Web Handlers settings body

I am so sorry for making some confusion. Please ignore the first PR; I made some stupid mistake.

Replace deprecated substr() with slice() in the codebase

if it is still open, can I try to work on this?

Replace deprecated substr() with slice() in the codebase

@IamLizu Oh, I am sorry. I think I didn't check the PR. Yeah I think someone has already made a PR for this issue, and I will review it. thanks!...

Refactor: use slice() instead of deprecated substr() to avoid future issues

Hello, @sarraf1996. Maybe I am a bit late, but I also reviewed your PR by merging it locally, and tested it. It looks great to me too.

Refactor: use slice() instead of deprecated substr() to avoid future issues

@IamLizu Thanks for the great tip! I didn't know that. I'll definitely check it out!

Replace `var` with `let` and `const`

I would love to work on this. Can I make a PR for this? :)

Replace `var` with `let` and `const`

Hi @sarraf1996. Thank you so much for your feedback. I realize now that I didn’t fully consider the different environments where the project might be used. My intention was to...

Replace `var` with `let` and `const`

@sarraf1996 I have tested the `let` and `const` tokens with various Node.js versions. Without using `'use strict'`, they support up to `v6.17.1`. However, with `'use strict'` declared at the top...

Move database import/export to different part of Settings

@humphd I would love to work on this Issue :smiley: May I?

write a basic unit test for the command line app

Hi, Waren. I would like to work on this, may I try this?