Amir Pauker

Results 6 comments of Amir Pauker

Worker hits ASSERT condition in production

@jmillan thanks for looking into it. We are using version 3.12.12. Unfortunately, it happens in a production environment therefore its harder to get detailed logs or STR for it. It...

Worker hits ASSERT condition in production

thanks, fwiw there were no significant changes to RateCalculator.cpp over the last 2 years. https://github.com/versatica/mediasoup/commits/v3/worker/src/RTC/RateCalculator.cpp I suspect it might occur when https://github.com/versatica/mediasoup/blob/v3/worker/src/RTC/RateCalculator.cpp#L27 `nowMs - this->newestItemStartTime >= this->itemSizeMs` and https://github.com/versatica/mediasoup/blob/v3/worker/src/RTC/RateCalculator.cpp#L32 `this->newestItemIndex...

Worker hits ASSERT condition in production

> > probably just logging an error and resting the RateCalculator will be more appropriate error handling > > Defensive programming hides real bugs. We don't do that. If something...

Worker hits ASSERT condition in production

> If there was a memory corruption somewhere, side-effects might be unexpected. This needs to be confirmed on latest version first. I am not sure how fast we can get...

Worker hits ASSERT condition in production

We patched 3.12.12 by using ` MS_ASSERT( this->newestItemIndex != this->oldestItemIndex || this->oldestItemIndex == -1 || this->newestItemIndex, "newest index overlaps with the oldest one"); ` I will let you know if...

Worker hits ASSERT condition in production

Sure, we'll do. thanks