hulk

Results 524 comments of hulk

@fdzuJ Would you mind having a try at the latest version, it should be resolved now. cc @alamb

@AntiTopQuark Thanks for your efforts. Would you mind adding a Go test case for this?

> While adding cases, it was found that there were no corresponding error messages, so error codes were added and reported in many places involving batch processing Yes, that makes...

@AntiTopQuark One comment inline, rest are good to me. Could anyone also have a look at this PR? @PragmaTwice @torwig @caipengbo @mapleFU

> Also cc @PragmaTwice > > Do we need some macro like `RETURN_NOT_OK`, `RETURN_NOT_OK_FROM_ROCKSDB`? @mapleFU @AntiTopQuark `RETURN_IF_ERR` is also good for this?

Yes, let's discuss this in new issue.

@SpencerTorres I'm not sure if it sounds good to introduce [clickhouse-sql-parser](https://github.com/AfterShip/clickhouse-sql-parser) to parse the query instead of using regex. I would be happy to submit a PR if this sounds...

> [@git-hulk](https://github.com/git-hulk) I'm concerned about the memory usage and latency this would add just to extract the column names. I'm also cautious about adding new dependencies. > > I think...

@yezhizi Not yet. Thanks for your interest. This task might depend on #2940, and it would be better to start working on that.

> Seems that this command is implemented as scan and MDel? > > I'm not sure should `deleterange` supports prefix delete ( which could implemented with the help of `rocksdb::DeleteRange`...