hulk

Results 524 comments of hulk

@zweix123 Assigned, thank you! Could you please propose the design before starting implementation? So that we can discuss the design in the early stage.

@zweix123 Thank you! There's no rush, it's good to propose the design while you get time and are ready to review.

Generally looks good, just one comment inline. Thank you!

> Hi, I've reviewed [#1301](https://github.com/apache/kvrocks/issues/1301) and [#2458](https://github.com/apache/kvrocks/issues/2458). Based on my understanding, the requirement of this task is to wrap a RocksDB API that takes a set of String/Hash-type key-value pairs...

@raffertyyu Thanks for your interest. I'm not sure if @yezhizi is working on this.

@yezhizi Thanks for your feedback. Assigned to @raffertyyu.

@greatsharp Except for the above comments, I believe we should NOT support the `clear` subcommand in `SLOTSIZE`, which makes no sense(also, this command is marked as read-only).

@greatsharp I'm generally good with the current implementation, with a few comments. Could you please add Go test cases for those commands? cc @PragmaTwice

LGTM, one more comment: `GetSlotStats` should also only allow to get/scan the slot that belongs to the node. And can clean the old stats if the slot has been moved....