Girts

Hi, thank you for the great package! One suggestion I have is to consider breaking apart the package into SVD parser and a separate data package. I'm currently using just...

work buffer passed to SPIFFS_mount must be aligned on some platforms

3

I'm seeing SPIFFS_mount() crash due to what looks like an unaligned memory access. Specifically, trying to access [obj_lu_buf[cur_entry-entry_offset]](https://github.com/pellepl/spiffs/blob/master/src/spiffs_nucleus.c#L179). This is on an ARM Cortex-M0. I do have SPIFFS_ALIGNED_OBJECT_INDEX_TABLES set to...

Pass in loop to PluginManager

3

If `loop` is passed to `MQTTClient`, previously it was not passed down to `PluginManager`, which could potentially grab a different loop from `asyncio.get_event_loop()`, resulting in a separate event loop being...

which_one_of returns incorrect value for nested assignments

4

If a `oneof` contains a submessage, and a field is assigned to this submessage, `which_one_of` does not report the submessage. Here is a proto file, generated code and code to...

Auto-wrapping long lines

2

It's probably a quite tricky thing to implement, but it would be nice if there was an option to autowrap long (e.g., > 79 chars) lines. Some sort of heuristics...

useCommitSHAInURL=false not working

1

I have `useCommitSHAInURL` set to `false`, but I still see SHAs in the GitHub URLs. Looking at the lines in [extension.js](https://github.com/ziyasal/vscode-open-in-github/blob/288b0b1ac753c1b3327b4df36a89b3648fc72413/src/extension.js#L82-L87), should the first arg to `cb(provider.webUrl(sha, [..]));` lines be...

variant of wait() that guarantees that predicate matches when it returns

4

Would there be interest in adding a variant of `wait` that only returns if the predicate is still `True`? I find that I sometimes need to write stuff like: ```...

limit accessible paths

4

Previously one could browse the whole filesystem on the machine that `snakeviz` server was running on. Now we limit what can be viewed to the filename that was passed in...

Break out input_state constants into settings

1

This takes 3 hardcoded constants from `input_state.rs` and puts them in a `InputOptions` struct that then gets added to `Options`. This allows adjusting these values at runtime, for example, to...