Davide Girardi comments

Results 8 comments of


                                            Davide Girardi

[Metricbeat] Add Data Granularity config option for AWS Cloudwatch metrics

cc @ravikesarwani I think it would be good to have your input on the docs-related changes

[Metricbeat] Add Data Granularity config option for AWS Cloudwatch metrics

/test

[Metricbeat] Add Data Granularity config option for AWS Cloudwatch metrics

Thanks @legoguy1000 for adding this :) . I am currently keeping this PR on hold as we might have some refactoring to do, as follow-up of https://github.com/elastic/beats/pull/33105 (cc @kaiyan-sheng )

Add header medatata flag

@tommyers-elastic Yes, we'd need to document the new parameter, if we go this route. However, based on Joao's comment here https://github.com/elastic/obs-infraobs-team/issues/810#issuecomment-1266687847, this PR might not be needed anymore.

[ESF] Add ability to disable document enrichment

Working directly on this plugin, we can avoid adding additional metadata introducing a new config value, and use it as flag to add / not add the header medatata, together...

[ESF] Add ability to disable document enrichment

cc @jsvd

[ESF] Add ability to disable document enrichment

I think we can close this as not needed anymore :) (cc @yaauie @roaksoax @tommyers-elastic )

Add header medatata flag

Closing as not needed anymore (see https://github.com/elastic/obs-infraobs-team/issues/842 )