Giridhar Trivedi
Giridhar Trivedi
\cc @uweigand
@jaredpar , The suggested changes have been incorporated and all tests are passing. Would you mind reviewing it one more time ?
yes.. If above repo paths are given, it will throw an error if /dotnet/runtime repo is given and the condition below will fail ``` # Basic checks for valid paths...
Hence I think, The code needs to be changed from `set(CORECLR_SRC_DIR "${CORECLR_DIR}/src")` to `set(CORECLR_SRC_DIR "${CORECLR_DIR}")` and Proper path of CORECLR_DIR should be passed as `/dotnet/runtime/src/coreclr`
Let me know if its proper to provide the fix, i will submit.
Thanks. Microsoft is no more using `https://github.com/dotnet/coreclr ` repo. Active development is happening in `https://github.com/dotnet/runtime`. I Suppose we should be using this going further.
Can this be merged ?