girishji

Results 30 comments of girishji

Fixed the lint issue

Thanks, I fixed and committed (it says it cannot generate info.json, and I found a bug in the naming of keyboard to match dir name) On Sun, 31 Jul 2022...

I'll look into re2_extract when I get some time. Strange, dev version should install on Mac since I develop on Mac and it is the same code. I also tested...

maybe use ensure_installed = "all". leaving it as "maintained" gives error

> * should use custom matrix "lite" > > * currently not implementing debounce correctly I am using an optical matrix. Optical switches do not need debounce. It takes about...

Hello Joel, I made the changes you requested and commited. I have some questions, please see the github page. On Sun, 31 Jul 2022 at 16:50, Joel Challis ***@***.***> wrote:...

> ``` > Layout Layout: > ┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐ > │K0││K0││K0││K0││K0││K0││K0││K0││K0││K0││K0││K0││K0││K0││K0│ > └──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘ > ┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐ > │K1││K1││K1││K1││K1││K1││K1││K1││K1││K1││K1││K1││K1││K1││K1│ > └──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘ > ┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐ > │K2││K2││K2││K2││K2││K2││K2││K2││K2││K2││K2││K2││K2││K2││K2│ > └──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘ > ┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐ > │K3││K3││K3││K3││K3││K3││K3││K3││K3││K3││K3││K3││K3││K3││K3│ > └──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘ >...

> > I am using an optical matrix. Optical switches do not need debounce. It takes about 15us for phototransistor to rise and IO pin will read accurate values after...

Thank you, I think I have incorporated all suggestions

Please review and merge, thanks :)