Gireesh Punathil

Results 123 comments of Gireesh Punathil

had a quick look. `1532713819` == `0x5B5B5B5B`. This pattern is typically invalid block eye-catcher. That means, `pc` was either not allocated, or overwritten. can you run with `export MALLOCDEBUG=catch_overflow` on...

For me, the central part of this interface are [io_submit](http://man7.org/linux/man-pages/man2/io_submit.2.html) and [io_getevents](http://man7.org/linux/man-pages/man2/io_getevents.2.html) the mechanism of which is exactly what is covered within libuv, with epoll_wait primitive and the algorithms around...

> I wanted to make clear that from my limited testing Node.js is not throwing on floats. @jonchurch - my assertion is that `500.5` is definitely invalid, so throwing is...

as per the TC discussion, this is ready to merge, who is going to do that? @dougwilson , I see your red-X on this - is that still valid, or...

@dougwilson , @wesleytodd : we are ready to land this, isn't it? what is blocking this?

@dougwilson / @wesleytodd - can you either remove the red-X or clarify what your concern is? If it is just that one is waiting for other's approval, please state so,...

@dougwilson - I have addressed all the review comments, mostly following your suggestions `AS IS`. Please have a look and do the needful!

it has been 11 days since the last update. can we take this forward?

@dougwilson - I just squashed all the commits into one