girder_worker

girder_worker copied to clipboard

Document job event binding and output reference kwargs.

7

I've now used girder worker on 3 projects, and I've wanted this feature on all of them. What do people think about a new type of docker result hook that...

subdavis

Currently, if a docker task has the appropriate labels, we try to run the docker task with the `runtime='nvidia'` parameter. As of Docker 19.03, there is docker built-in support for...

manthey

File paths from docker transforms should be wrapped in quotes

1

I don't think it's docker-py's burden to do anything other than `' '.join(container_args)` If our transforms return strings that might have spaces, they also need to be quoted. Also random...

subdavis

girder_plugin settings for worker.api_url, worker.broker, worker.backend are not being picked up correctly

3

kotfic

Check if Celery Pinning is still necessary

23

@manthey I seem to recall we pinned celery to `celery>=4,

kotfic

Revoke integration tests are hanging

1

Both: + test_celery.py::test_celery_task_revoke + test_celery.py::test_celery_task_revoke_in_queue Are hanging and causing integration tests to fail. (See: https://github.com/girder/girder_worker/issues/191 maybe?) @cjh1 Would you be willing to take a look (and/or are these features still...

kotfic

`kwargs` argument passed to `POST /job` was not properly serialized.

Xarthisius

Girder worker mishandles keyword arguments in chained tasks. ## Steps to reproduce Consider the following task: ``` @girder_job(title='Test Kwargs') @app.task(bind=True) def kwargs_task(self, **kwargs): print('Got {}'.format(kwargs)) return kwargs ``` when executed...

Xarthisius

Docker in docker permission issue

1

When using the girder_worker docker image, unable to run docker from within the worker container due to permission issue. Specifically the docker group does not appear to be created and...

schorlton

I put this test together while investigating https://github.com/girder/girder_worker/issues/327 Many more tests should probably be written, but this at least demonstrates how to fully mock out the `docker_run` task for posterity's...

kotfic