Takayuki Nakata

> Hmm, I didn't think of the NaN behavior. That makes me lean towards removing that the f32::clamp and f64::clamp suggestions from this lint. IMHO it is a good point...

> I think the lint should warn for every decimal number, personally I think that the XOR operator is sufficiently rare that any use of it between two decimal numbers...

We follow the no merge-commit policy, so could you rebase, not merge? https://github.com/rust-lang/rust-clippy/blob/master/book/src/development/basics.md#pr

Sorry for the late reviewing. > I tried doing this for a few days and I'm pretty lost, in the test the last test that should warn (let _ =...

> Given the history of your branch I believe the easiest option is just to copy-paste your change in a new branch I agree.

What issue are you having trouble with? Feel free to ask it here or on [zulip](https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy).

There is no method `is_some_with` on `Option`. Do you mean [`is_some_and`](https://doc.rust-lang.org/std/option/enum.Option.html#method.is_some_and)?

Could you do a rebase, not merge commit? We follow no merge-commit policy. https://github.com/rust-lang/rust-clippy/blob/master/doc/basics.md#pr

@brleinad If you have any questions, you can ask me too. Or you can ask on the [zulip](https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy) chat.

This needs msrv: https://github.com/rust-lang/rust/blob/stable/RELEASES.md#version-1580-2022-01-13