Gino Miceli
Gino Miceli
@shobhitagarwal1612 @JSunde Any idea when we should be using `?attr/colorFoo` vs `@color/colorBar`? I don't quite understand yet how the two interact, would be good to establish a common approach.
@shobhitagarwal1612 @JSunde Proposed structure of new consolidated styles, by example: https://github.com/google/ground-android/blob/f0efc1ee87be18657023917f46ad6e933c1d1aee/ground/src/main/res/values/styles.xml#L218-L252
Automated testing is in place, adding coverage is a high-level concern owned by the whole team.
> In the current iteration, we don't show the gps lock button in "Offline Area" screen. Should we enable the gps as soon as the screen is loaded? I think...
Moving to Coroutines so this is obsolete.
The number of retries is bounded, so even unrecoverable errors will cause photo upload to be aborted (eventually).
Fair point. After all, this is a tagged as "code health", not "bug", in which case I think we could keep it open.
There is now a referential integration constraints between LOI and submission in local db, so this can no longer occur.
> just Hi Scott, yes, I think that makes sense, though it's lower priority (only be needed for GA), since for pilots we'll always provide imagery.
Thanks for sharing your thoughts on this. Cloud Functions which read and/or write to Firestore will invariably duplicate logic in their corresponding web, Android, and iOS apps; in those cases...