ginger

Results 81 comments of ginger

Hey there @massimo-cassandro, I really like this idea! Making theming more accessible with custom props is a great addition. I'm going to add the feature request label so we can...

Thinking back to this now, here's a general idea of what it could look like (just brainstorming so values aren't real). As far as "decisions" that need to be made,...

My only hesitation with using the `:root` is that everything uses `:root`, for example Bootstrap. ![image](https://github.com/biati-digital/glightbox/assets/26461046/99789540-ef45-46be-b916-682142bf1b5b) But not enough to be a stick in the mud about it :)

You actually reminded me of another point which is dealing with the length of some properties in CSS being converted to custom properties: ```scss .glightbox-container { // This is my...

Interesting idea, I think for right now this is out of scope. I think it would be worth revisiting once the next version comes out.

@felixranesberger Actually, I missed something, we need you to run the development command before we can merge. There's a guide [in CONTRIBUTING.md](https://github.com/biati-digital/glightbox/blob/master/CONTRIBUTING.md)

Yeah it’s a little confusing, enter `npm run watch` in the CLI, then save a file. That will run all the build scripts.

I get that, it would be nice if we (collaborators and maintainers) could run those commands inside the repo without dealing with all the Actions and what not. Thankfully *knocks...

Awesome, much appreciated! @biati-digital should be all good now.

I'll reach out and see if they can give a final look, both of our jobs keep us pretty limited in the "free time" department.