ginger
ginger
One way to ensure the package size stays small would be to add an upper limit using something like [size-limit](https://www.npmjs.com/package/size-limit). I pulled together a draft PR at #48 to put...
I think that minimizing the ideas in complexity is a good idea. If I go through the original shortlist, this is where I fall on lib concern vs user concern:...
The main reason I like using the `data-*` instead of on the element object is that it "exists" somewhere. ```html Does this div have data attached to it? Or did...
The GLightboxInit needs to be updated since the constructor only takes a config object. As for setting private methods, I think thats fine. Is there something that makes you doubt...
I am no Typescript expert, so I'm interested in your opinion too
Re: the todo in the last commit, I think this would help https://www.typescriptlang.org/docs/handbook/utility-types.html#returntypetype ```ts type init = ReturnType GLightboxInstance> ``` this could also be a wild goose chase.
> I am not sure about this method `getElementIndex(node: Node) {...}` about the type of the parameter, previously I had nothing, not sure if this is the correct type. Also...
 My god, they’ve done it! I’ll double review it once I get free time again, but seriously didn’t think it would be that clean of a solution.
Even still, great find! I was looking through and found a place where the function arguments don't match up. Here [on line 340](https://github.com/biati-digital/glightbox/blob/0e0dd79cf8452e9f1f84870584b2417a8d45f7f0/index.d.ts#L340-L348) of the `d.ts` file, the `open` and...
The existing changes are probably safe to copy and paste into your own `.d.ts` file. There is more stuff internally that needs some additional typing before it makes sense to...