gin icon indicating copy to clipboard operation
gin copied to clipboard

Fix NegotiateFormat

Open eleven26 opened this issue 1 year ago • 2 comments

Fix issue #3241

When the length of the offered mime type string is inconsistent with the request's accepted mime length, it may cause a panic, but it should actually return an empty string.

eleven26 avatar Jul 12 '22 13:07 eleven26

Codecov Report

Merging #3243 (b593c6e) into master (b57163a) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3243   +/-   ##
=======================================
  Coverage   98.37%   98.38%           
=======================================
  Files          43       43           
  Lines        3148     3149    +1     
=======================================
+ Hits         3097     3098    +1     
  Misses         38       38           
  Partials       13       13           
Flag Coverage Δ
go-1.15 98.38% <100.00%> (+<0.01%) :arrow_up:
go-1.16 98.35% <100.00%> (+<0.01%) :arrow_up:
go-1.17 98.28% <100.00%> (+<0.01%) :arrow_up:
go-1.18 98.28% <100.00%> (+<0.01%) :arrow_up:
macos-latest 98.38% <100.00%> (+<0.01%) :arrow_up:
nomsgpack 98.35% <100.00%> (+<0.01%) :arrow_up:
ubuntu-latest 98.38% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
context.go 98.46% <100.00%> (+<0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b57163a...b593c6e. Read the comment docs.

codecov[bot] avatar Jul 14 '22 01:07 codecov[bot]

please also review the pull request @dawkaka thanks!

thinkerou avatar Jul 17 '22 15:07 thinkerou