gin icon indicating copy to clipboard operation
gin copied to clipboard

Fix Allow header according to RFC 7231

Open unbyte opened this issue 3 years ago • 3 comments

6.5.5. 405 Method Not Allowed

The 405 (Method Not Allowed) status code indicates that the method received in the request-line is known by the origin server but not supported by the target resource. The origin server MUST generate an Allow header field in a 405 response containing a list of the target resource's currently supported methods.

close #2397

unbyte avatar Aug 22 '20 08:08 unbyte

Codecov Report

Merging #2476 (9af3803) into master (b01605b) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2476   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files          41       41           
  Lines        1989     1993    +4     
=======================================
+ Hits         1962     1966    +4     
  Misses         15       15           
  Partials       12       12           
Impacted Files Coverage Δ
gin.go 99.02% <100.00%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b01605b...9af3803. Read the comment docs.

codecov[bot] avatar Aug 22 '20 08:08 codecov[bot]

@unbyte @appleboy Any news on this?

antonjah avatar Mar 16 '22 06:03 antonjah

@antonjah conflicts

appleboy avatar Mar 16 '22 08:03 appleboy

I opened a new PR using @unbyte's commits but fixing conflicts, hoping this can get merged & released soon :)

Crocmagnon avatar Oct 17 '23 16:10 Crocmagnon

closed PR and move to https://github.com/gin-gonic/gin/pull/3759

appleboy avatar Feb 06 '24 02:02 appleboy