gin
gin copied to clipboard
treat http.ErrAbortHandler as broken pipe too
cc #1714
similar to https://github.com/gorilla/handlers/pull/159/files
Was looking for this as well. Would it make sense to use errors.Is instead of using == to compare, in case something wraps this error with another error?
Codecov Report
Merging #2590 (01c93c1) into master (4d2dad5) will decrease coverage by
0.09%. The diff coverage is0.00%.
@@ Coverage Diff @@
## master #2590 +/- ##
==========================================
- Coverage 98.49% 98.39% -0.10%
==========================================
Files 41 41
Lines 1989 1991 +2
==========================================
Hits 1959 1959
- Misses 17 18 +1
- Partials 13 14 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| recovery.go | 94.52% <0.00%> (-2.67%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 4d2dad5...01c93c1. Read the comment docs.
Also running in to this one, is it possible to get this merged?
Here is the info from Golang on this being the proper way to handle the aborts:
https://github.com/golang/go/issues/28239 https://github.com/golang/go/issues/23643