gin icon indicating copy to clipboard operation
gin copied to clipboard

treat http.ErrAbortHandler as broken pipe too

Open tmm1 opened this issue 4 years ago • 3 comments

cc #1714

similar to https://github.com/gorilla/handlers/pull/159/files

tmm1 avatar Dec 23 '20 00:12 tmm1

Was looking for this as well. Would it make sense to use errors.Is instead of using == to compare, in case something wraps this error with another error?

m1o1 avatar Dec 30 '20 20:12 m1o1

Codecov Report

Merging #2590 (01c93c1) into master (4d2dad5) will decrease coverage by 0.09%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2590      +/-   ##
==========================================
- Coverage   98.49%   98.39%   -0.10%     
==========================================
  Files          41       41              
  Lines        1989     1991       +2     
==========================================
  Hits         1959     1959              
- Misses         17       18       +1     
- Partials       13       14       +1     
Impacted Files Coverage Δ
recovery.go 94.52% <0.00%> (-2.67%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4d2dad5...01c93c1. Read the comment docs.

codecov[bot] avatar Jan 04 '21 05:01 codecov[bot]

Also running in to this one, is it possible to get this merged?

Here is the info from Golang on this being the proper way to handle the aborts:

https://github.com/golang/go/issues/28239 https://github.com/golang/go/issues/23643

maggie44 avatar Nov 01 '23 06:11 maggie44