gin-ahirsch

> `Building for Visual Studio 16 2019` I'd guess it's creating a Visual Studio project file. You can change the output format using either `-G'MSYS Makefiles'` or `-G'MinGW Makefiles'` depending...

The documentation states pretty clearly that it groups "consecutive elements". The example also shows this, though still I think #375 is a good change anyway. I don't find the name...

I'd prefer more generic methods that allow dealing with duplicates. `get_value()` could return an iterator instead and can easily be implemented: `self.attributes().filter(|attr| attr.key == key)`. If just a single attribute...

I fixed some issues with the last commit. It actually builds now :)

Rebased with the following diff: ``` +diff --git a/src/data/logfiltereddata.cpp b/src/data/logfiltereddata.cpp index 59bcc93..cc231ef 100644 --- a/src/data/logfiltereddata.cpp +++ b/src/data/logfiltereddata.cpp @@ -258,7 +258,7 @@ void LogFilteredData::updateMaxLengthMarks( qint64 removed_line ) if ( sourceLogData_->getLineLength( removed_line...

While implementing the modification-detection I stumbled upon a couple of questions: Should the view in "Loadable" be updated to include the modifications to the filter? Currently (not yet pushed) I...

The branch is shaping up nicely. Currently, modified version of loaded filters are only visible in the "Loadable" tab via a modification-icon. The item in the list is not changed...

@garyee Check out https://github.com/gin-ahirsch/glogg/tree/filter-files-for-upstream, I'm really just waiting on #230 or #236 to be merged before opening a PR. Note that these, and some other, changes are included in that...

I pushed two bug-fixes and changed the loaded- and modified-icons to resemble an "L" and an "M" respectively.

Do you get this with a build from master? This might have gotten fixed via https://github.com/nickbnf/glogg/commit/9f850936f193b6e0057829e50d76cbf76e3a62c7.