Alberto Gimeno

Results 20 comments of Alberto Gimeno

That's because the connection is still alive. I'll check how the connection is handled and if necessary provide a way to close it or close it automatically.

Thanks a lot @contra I've merged all your PRs and published a new version. Thanks a lot again!

PRs are welcome :)

Sorry, since I didn't see it linked I was not aware of them.

This looks really good. I'll take a look asap. Can you add tests for this?

I thought this project was about not shipping your own nodejs + chrome runtime, but rather making an electron-mostly-compatible framework using just what your OS has.

I've created this PR: https://github.com/ninjaprawn/electrino/pull/1/files That adds better support. Nevertheless the whole thing should follow this documentation: https://nodejs.org/api/modules.html#modules_all_together Some things that we will need to implement: - requires to relative...

@amilajack my PR improved things, but was not implementing everything. I'm unsure about the state of the current implementation. The implementation should follow this spec https://nodejs.org/api/modules.html#modules_all_together