Giles Harper-Donnelly

Results 9 comments of Giles Harper-Donnelly

@maheswarantp no need for playing around with paths with: `sys.path.insert(0,os.path.abspath(os.path.dirname(__file__)))` (e.g. [here](https://github.com/maheswarantp/JSL/blob/f25a2ee1ed92b1f7bd4427db47b92c7113c626c6/jsl/lds/kalman_sampler_test.py#L1-L4)). You can just use absolute imports as is done in #54 (and discussed in issue #53).

@maheswarantp re `kalman_filter_initial_prior_test()`, I imagine having unseeded random numbers (i.e. the calls to `np.random`) in a test might make it quite hard to debug because it will be hard to...

Ah great! I'll make a PR and perhaps take a look into the docstring.

Hi @AndyWeasley2004, I'm not sure I have totally understood your question correctly but perhaps the following might be helpful. There is an example at the start of the [demo](https://probml.github.io/dynamax/notebooks/hmm/casino_hmm_learning.html) of...

Hi @rajasekharporeddy thanks for confirming this! I had closed my associated PR when I saw that the feature had been merged but I forgot to also update this issue. Given...

Hi @canyon289! Nice catch! Yes I think there is a problem in the equation in the docs which should read: ```math \underbrace{\begin{pmatrix} u_t\\ v_t \\ \dot{u}_t \\\dot{v}_t \end{pmatrix}}_{z_t} ``` this...

This looks really neat @calebweinreb! One question about the timing results - is that on a cpu or gpu? I remember the behaviour being a bit different for different backends...

Hi @ghuckins thanks for showing interest in the library! Yes unfortunately the `sklearn` bits of code won't naturally play nice with lots of jax's tools. From what I can tell,...

Hi @weigcdsb, I'm not sure I totally understand your use case, would you be able to explain it in some more detail and we'll see if I can help 😄....